Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow phase look-up in Mixtures by both name and phase id #727

Closed
ischoegl opened this issue Oct 8, 2019 · 1 comment
Closed

Allow phase look-up in Mixtures by both name and phase id #727

ischoegl opened this issue Oct 8, 2019 · 1 comment

Comments

@ischoegl
Copy link
Member

ischoegl commented Oct 8, 2019

Cantera version

all

Operating System

all

Python/MATLAB version

Python

Expected Behavior

The index of a phase ('Solution') within mixtures can be identified either by name or ID
(using the Mixture.phase_index method)

Actual Behavior

Mixture.phase_index currently requires name.
@ischoegl ischoegl mentioned this issue Oct 8, 2019
Merged
@ischoegl
Copy link
Member Author

Not needed if Phase::id is deprecated after #696 and #724

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ischoegl