Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diff of removing trailing whitespace is confusing #19

Open
ianhi opened this issue Feb 5, 2021 · 1 comment
Open

Diff of removing trailing whitespace is confusing #19

ianhi opened this issue Feb 5, 2021 · 1 comment

Comments

@ianhi
Copy link
Contributor

ianhi commented Feb 5, 2021

If you have a diff that only removes trailing whitespace it is a bit confusing because on first inspection the two lines look the same:
image

@Carreau
Copy link
Owner

Carreau commented Feb 5, 2021

Yep +1 to that.

Either this can be fixed in Pygments's DiffLexer,
or instead of just generating the diff text and highlighting it, we could directly iterate through the diff's Operations and be smarter about the highlighting.

Or if you find another diff-highlighting engine that does it, that woudl be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants