Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax external tileset restrictions #211

Closed
lilleyse opened this issue Apr 12, 2017 · 3 comments
Closed

Relax external tileset restrictions #211

lilleyse opened this issue Apr 12, 2017 · 3 comments
Assignees

Comments

@lilleyse
Copy link
Contributor

From the spec:

root.geometricError === tile.geometricError,
root.refine === tile.refine, and
root.boundingVolume === tile.content.boundingVolume (or root.boundingVolume === tile.boundingVolume when tile.content.boundingVolume is undefined).
root.viewerRequestVolume === tile.viewerRequestVolume or root.viewerRequestVolume is undefined.

Are these restrictions actually needed? This makes serving dynamic external tilesets harder.

@lilleyse lilleyse added the 1.0 label Apr 12, 2017
@lilleyse
Copy link
Contributor Author

lilleyse commented May 1, 2017

@pjcozzi any thoughts here? Losing the restrictions should not present much of a problem for clients.

@pjcozzi
Copy link
Contributor

pjcozzi commented May 18, 2017

The intention was to prevent senseless consistences and to semantically treat the tileset's root as the other tileset's leaf tile...all in the name of making the traversal implementation easier in theory.

If these restrictions do not help the implementation in practice and it would not be possible to make technically valid but problematic tilesets then let's relax the restrictions.

@ggetz
Copy link
Contributor

ggetz commented May 11, 2018

Resolved in #301

@ggetz ggetz closed this as completed May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants