-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extensions properties should point to extensions schema #495
Comments
@javagl good timing - I already did this in https://github.com/CesiumGS/3d-tiles/tree/3d-tiles-next-json-schema-2020-12 and plan to open a PR soon. |
Fixed in #497 |
I think they are still explicitly listed, e.g. https://github.com/CesiumGS/3d-tiles/blob/main/specification/schema/boundingVolume.schema.json#L40 - I hope it's OK to reopen EDIT: On a second thought, this issue was mainly about referring to the actual schema, and not so much about repeating the |
3D Tiles schemas are mostly followed what glTF is doing. If glTF changes we should change here as well, but until then maybe not worry about it? |
Based on a recent comment, ... we can stop putting empty name, extras, and extensions everywhere", but the next comment indicated that this would likely happen after the existing glTF extension schemas have been updated to the latest JSON Schema version We could do that change here and remove the I think it's OK to leave this issue open as a reminder, but again: If it should be closed because there is no immediate action, then that's also fine for me. |
I think this issue is resolved. If there are cases where it was not resolved, this issue can be reopened. |
The
extensions
property in the schema files of extensions is currently defined as(for example, here, but it appears to be done consistently like that for the extensions).
In the core schema, the extensions are pointing to the
extension.schema.json
, via(for example, here, but it appears to be done consistently like that for the core)
I think that the extensions should also point to the
extensions.schema.json
(despite the difficulty that might arise from "nested extensions" - they are currently required, e.g for combining3DTILES_multiple_contents
and3DTILES_metadata
).The same is currently true for the glTF
gltf.EXT_mesh_features.schema.json
, which should similarly point to the glTFextension.schema.json
.The text was updated successfully, but these errors were encountered: