From 4d7a48d7b3834ffb0fbc06f65d61c8ff3649dc35 Mon Sep 17 00:00:00 2001 From: Sean Lilley Date: Wed, 29 May 2019 13:14:35 -0400 Subject: [PATCH] Fix credits --- CHANGES.md | 2 ++ Source/Scene/Scene.js | 5 ++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/CHANGES.md b/CHANGES.md index 456fbba0075c..95da223676e3 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -1,5 +1,6 @@ Change Log ========== + ### 1.58 - 2019-06-03 ##### Additions :tada: @@ -13,6 +14,7 @@ Change Log * Fixed an edge case where Cesium would provide ion access token credentials to non-ion servers if the actual asset entrypoint was being hosted by ion. [#7839](https://github.com/AnalyticalGraphicsInc/cesium/pull/7839) * Fixed a bug that caused Cesium to request non-existent tiles for terrain tilesets lacking tile availability, i.e. a `layer.json` file. * Fixed memory leak when removing entities that had a `HeightReference` of `CLAMP_TO_GROUND` or `RELATIVE_TO_GROUND`. This includes when removing a `DataSource`. +* Fixed 3D Tiles credits not being shown in the data attribution box. ### 1.57 - 2019-05-01 diff --git a/Source/Scene/Scene.js b/Source/Scene/Scene.js index a3a89605b115..096599f8d141 100644 --- a/Source/Scene/Scene.js +++ b/Source/Scene/Scene.js @@ -3210,6 +3210,7 @@ define([ scene._pickPositionCacheDirty = true; frameState.creditDisplay.update(); + frameState.creditDisplay.beginFrame(); } function postPassesUpdate(scene) { @@ -3218,6 +3219,7 @@ define([ primitives.postPassesUpdate(frameState); RequestScheduler.update(); + frameState.creditDisplay.endFrame(); } var scratchBackgroundColor = new Color(); @@ -3245,8 +3247,6 @@ define([ } frameState.backgroundColor = backgroundColor; - frameState.creditDisplay.beginFrame(); - scene.fog.update(frameState); us.update(frameState); @@ -3292,7 +3292,6 @@ define([ } } - frameState.creditDisplay.endFrame(); context.endFrame(); }