Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cesium usability improvements #1139

Closed
2 of 4 tasks
pjcozzi opened this issue Sep 11, 2013 · 6 comments
Closed
2 of 4 tasks

Cesium usability improvements #1139

pjcozzi opened this issue Sep 11, 2013 · 6 comments
Labels
breaking change cleanup good first issue An opportunity for first time contributors

Comments

@pjcozzi
Copy link
Contributor

pjcozzi commented Sep 11, 2013

A few notes from past hackathons.

  • Inconsistent variable names makes it hard to copy and paste code. Sandcastle has widget, HelloWorld.html has cesiumWidget.
  • What is the future of Sandcastle.highlight? It gets in the way when copying and pasting into HelloWorld.html, and the mouse-over highlighting gets in the way by changing scroll position away from where we were reading. Perhaps reorganizing the Sandcastle examples will eliminate the name for this feature.
  • Can billboard.imageIndex reference an image that doesn’t exist yet? In general, making the texture atlas should be easier.
  • Not sure if this is still true: "working with camera flights is extremely painful. Even worse when starting/ending views are in different reference frames." @bagnell?
@pjcozzi
Copy link
Contributor Author

pjcozzi commented Mar 27, 2014

For the top bullet, sometimes it is also called viewer like in the camera tutorial.

@emackey
Copy link
Contributor

emackey commented Mar 28, 2014

@pjcozzi note that viewer and widget are two different widgets.

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Mar 28, 2014

@pjcozzi note that viewer and widget are two different widgets.

Yes, of course. Using them 50/50 throughout the examples is confusing though, especially for new folks looking to copy and paste. I'm still looking into what is best, e.g., use viewer just about everywhere, always call it widget, etc.

@emackey
Copy link
Contributor

emackey commented Mar 28, 2014

Agreed, it's confusing. Not sure that viewer is correct for 100% of the examples though, but I would like to see viewer used more frequently than it is. This could possibly be done by "turning off" sub-widgets that don't apply to certain examples. For instance, some examples avoid viewer just to avoid a scene mode switch, when they could just turn off the scene mode widget and use the rest of viewer. In other cases though, we want folks to focus on example content, and not have viewer's UI in the way. Not sure the best answer.

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Mar 28, 2014

Agreed. Perhaps we just about always use it but turn things off as needed. The examples are inconsistent now and a newbie will not always know widget.scene can be used in place of viewer.scene, for example.

Open to other folk's thoughts here.

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Jun 10, 2014

Closing as now duplicate with #1688 (texture atlas) and #1060 (camera).

@pjcozzi pjcozzi closed this as completed Jun 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change cleanup good first issue An opportunity for first time contributors
Projects
None yet
Development

No branches or pull requests

2 participants