Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent parameters for camera flyTo/setView #3088

Closed
hpinkos opened this issue Oct 14, 2015 · 1 comment
Closed

Consistent parameters for camera flyTo/setView #3088

hpinkos opened this issue Oct 14, 2015 · 1 comment
Labels
breaking change cleanup good first issue An opportunity for first time contributors type - enhancement

Comments

@hpinkos
Copy link
Contributor

hpinkos commented Oct 14, 2015

For setting the camera view, it would be nice if camera.flyTo and camera.setView used the same parameters.

I like that flyTo can take either a position or a rectangle as a destination, it would be nice if setView had the same behavior. Maybe camera.viewRectangle can be consolidated into setView.

Or, we could possibly consolidate it all into 1 function where duration = 0 would use the setView logic (which is something we do in a few different widgets).
@pjcozzi pjcozzi added cleanup good first issue An opportunity for first time contributors breaking change labels Oct 14, 2015
@hpinkos hpinkos mentioned this issue Oct 15, 2015
Merged
@hpinkos hpinkos closed this as completed Oct 24, 2015
@hpinkos
Copy link
Contributor Author

hpinkos commented Oct 24, 2015

resolved in #3100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change cleanup good first issue An opportunity for first time contributors type - enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pjcozzi @hpinkos