Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The sun isn't being rendered #3800

Closed
lasalvavida opened this issue Apr 4, 2016 · 4 comments
Closed

The sun isn't being rendered #3800

lasalvavida opened this issue Apr 4, 2016 · 4 comments
Labels
priority - next release type - bug

Comments

@lasalvavida
Copy link
Contributor

Pretty self explanatory.
@lasalvavida
Copy link
Contributor Author

I've narrowed this down to a change that occurred between March 23rd and 24th

@lasalvavida
Copy link
Contributor Author

Narrowed down to revision b937a5c, Infinite horizontal scrolling in 2D; the sun is still rendered in the previous revision 6872342. Working on a fix.

Edit: Update
git checkout 1063c83 // no sun
git checkout 1bc2db6 // let there be light

@pjcozzi
Copy link
Contributor

pjcozzi commented Apr 4, 2016

Thanks for finding and narrowing it down. @bagnell let's fix this for the next release.

@lasalvavida lasalvavida mentioned this issue Apr 4, 2016
Merged
@lilleyse
Copy link
Contributor

lilleyse commented Apr 4, 2016

Fixed in #3801

@lilleyse lilleyse closed this as completed Apr 4, 2016
@jmgomezpoveda jmgomezpoveda mentioned this issue Apr 29, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority - next release type - bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pjcozzi @lilleyse @lasalvavida