Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ground clamping broken in 2D and CV #4380

Open
mramato opened this issue Sep 29, 2016 · 4 comments
Open

Ground clamping broken in 2D and CV #4380

mramato opened this issue Sep 29, 2016 · 4 comments

Comments

@mramato
Copy link
Contributor

mramato commented Sep 29, 2016

As discussed in #4240

  1. Load the KML demo.
  2. Switch to 2D
  3. Billboards are broken (Similar problems in Columbus View)

image

May be the same root cause as #4300 and #4062.

We should really fix this before the next release.

@pjcozzi
Copy link
Contributor

pjcozzi commented Sep 29, 2016

We should really fix this before the next release.

+1

@mramato
Copy link
Contributor Author

mramato commented Oct 21, 2016

I'm about to open a pull request which fixes several clampiing issues, but it turns out that this particular issue is fundamentally a performance problem. If you just sit there and wait forever it eventually finishes and fixes itself. You can also see this by disabling the time slicing (which also makes it go a bit faster). In addition to simply profiling and improving the hot spots, we might need a slightly different approach here in order to keep this acceptably fast (I have some ideas, but I need to experiment some more first).

@mramato
Copy link
Contributor Author

mramato commented Oct 21, 2016

Also, we disabled billboard clamping by default for KML because of this, so in order to reproduce this you need to set clampToGround to true in the Sandcastle example

@mramato
Copy link
Contributor Author

mramato commented Oct 21, 2016

I'm removing the "next release" tag since this is no longer the default behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants