Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clustering doesn't work well in 2D and CV #4538

Closed
mramato opened this issue Oct 27, 2016 · 18 comments
Closed

Clustering doesn't work well in 2D and CV #4538

mramato opened this issue Oct 27, 2016 · 18 comments

Comments

@mramato
Copy link
Contributor

mramato commented Oct 27, 2016

When in 2D or Columbus View, the left side of the screen does not show any billboards if clustering is enabled. Here's a sample from a large CZML file of air traffic. With clustering disabled, everything is fine. Once it's enabled, lots of stuff on the left side disappears. (Even stuff that's clearly not part of a cluster).

clustering

I ran into similar oddness when using the default clustering example, lots of stuff disappearing in 2D that shouldn't be.

@jeffwhitty
Copy link

I noticed a similar behaviour, my entities are all loaded manually from a web service (20,000 calls to getOrCreateEntity()) and with clustering on the numbers are nowhere near the right total for all of my entities and the left side was largely blank or very thinned out.

No CZML or dynamic time happening, just a bunch of entities (some billboards, some points).

@pjcozzi
Copy link
Contributor

pjcozzi commented Oct 28, 2016

@bagnell what is the level of effort here? If it's reasonable, seems like we should fix this soon or disable in 2D/CV until we have time to fix this.

@rutsky
Copy link
Contributor

rutsky commented Oct 28, 2016

This issue also reproducible in Clustering demo, almost no features are inside Atlantic ocean (edited: this is expected):

2016-10-28_20 28 49_1

however if I switch to 2D lots of feature will appear there (edited: this is a bug):

2016-10-28_20 29 24_1

@mramato
Copy link
Contributor Author

mramato commented Oct 28, 2016

I previously thought this was 2D/CV only, but @rutsky's screen shots above make it looks like a general problem.

@rutsky
Copy link
Contributor

rutsky commented Oct 28, 2016

@mramato my comment was about issue in 2D/CV only: there are no features in Atlantic ocean (which is correct), but they appear if I switch to 2D/CV. So I don't assert that clustering is not working in 3D.

@mramato
Copy link
Contributor Author

mramato commented Oct 28, 2016

Ahh, okay. Is that in master? You might be running into a separate issue if it's 1.26.

@rutsky
Copy link
Contributor

rutsky commented Oct 28, 2016

@macoda I'm observing appearing items not on their place when clustering in 2D in 1.26 release.
So my issue should be fixed in master and this bug report is about different issue?

@corygehr
Copy link

corygehr commented Nov 1, 2016

Just wanted to toss another vote in here for this issue - I'm seeing the exact same thing in the 2D view. My pins disappear until I zoom in to certain points. When I'm zoomed in super close it seems to be fine.

@mramato
Copy link
Contributor Author

mramato commented Nov 1, 2016

I've marked this issue for the next release so that we can either fix it (obviously preferred) or temporarily disable clustering in 2D/CV until we can figure out the problem.

CC @bagnell

@tfili
Copy link
Contributor

tfili commented Dec 1, 2016

@bagnell what's the plan for this?

@pjcozzi
Copy link
Contributor

pjcozzi commented Dec 1, 2016

Pushing to 1.29 to not hold up the release.

@hpinkos
Copy link
Contributor

hpinkos commented Dec 8, 2016

Also reported here: https://groups.google.com/forum/?hl=en#!topic/cesium-dev/JrZ60d1r_zk

I find it will be nothing to show at the moment when I convert to 2D from 3D, but move the camera ,it will show these entities

@pjcozzi
Copy link
Contributor

pjcozzi commented Dec 19, 2016

@bagnell this is an important one. What is the level of effort? Is it reasonable to aim to fix it soon or just disable it?

@pjcozzi
Copy link
Contributor

pjcozzi commented Dec 31, 2016

Pushing this to 1.30. Leaving it labeled next release since there is so much interest.

@hpinkos
Copy link
Contributor

hpinkos commented Feb 1, 2017

Guess we're pushing this to 1.31. Should we leave this labeled 'next release' or is it not as critical anymore?

@pjcozzi
Copy link
Contributor

pjcozzi commented Feb 1, 2017

Let's leave it next release; I also added it for the bug bash, #4897.

@lilleyse
Copy link
Contributor

@bagnell Is there time to get this in before the 1.31 release?

@bagnell
Copy link
Contributor

bagnell commented Feb 28, 2017

@lilleyse No, we'll need to push this to the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants