Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3D Tiles Inspector #4846

Closed
16 of 18 tasks
pjcozzi opened this issue Jan 10, 2017 · 2 comments
Closed
16 of 18 tasks

3D Tiles Inspector #4846

pjcozzi opened this issue Jan 10, 2017 · 2 comments

Comments

@pjcozzi
Copy link
Contributor

pjcozzi commented Jan 10, 2017

This will allow us to remove a lot of prototype and duplicate code in Sandcastle examples, and will allow users to embed the inspector in their apps for easily debugging and profiling.

The UI design is open-ended; feel free to make it much better than the collection of buttons in the Sandcastle examples.

Phase one is to just replace the debugging functionality already in the Sandcastle examples; we can do more pull requests as new features are needed. Do not worry about the current style options in the Sandcastle examples for the first pull request.

  • Features based on the debug options in the Sandcastle example: http://localhost:8080/Apps/Sandcastle/index.html?src=3D%20Tiles.html&label=Showcases
    • Show stats and Show pick stats. These could be shown in the inspector UI instead of the console. Keep the separation of the inspector and the 3D Tiles rendering clean; the inspector would just pull the fields from Cesium3DTileset.
    • Freeze frame
    • Colorize
    • Show bounding volumes, Show contents, and Show request volume
    • Change SSE - have a slider and be able to set an explicit value
    • Enable Dynamic SSE
      • Change density and factor - similiar to SSE above
    • Trim tiles cache
    • Enable picking
  • New features
    • Be able to pragmatically pass a tileset to the inspector
    • Be able to click on a tileset (when the inspector is open) to inspect it
    • Performance Display - just like the Cesium Inspector (for convenience)
    • Show Wireframe
    • Ignore batch table - should force a tileset reload
    • Show the url of a clicked tile
  • Remove similar code in the 3D Tiles Sandcastle examples (in the 3d-tiles branch and branches off of 3d-tiles) and instead add the 3D Tiles Inspector.

For @austinEng when ready.

@austinEng
Copy link
Contributor

Show stats and Show pick stats. These could be shown in the inspector UI instead of the console.

Does this mean to entirely remove console logging or to just show the information in the inspector as well? Logging of the stats is implemented within Cesium3DTileset and removing it would involve disabling the debug flags for statistics. We can still pull the statistics from the tileset as you said, but would doing so without debug flags be inconsistent?

@pjcozzi
Copy link
Contributor Author

pjcozzi commented Jan 17, 2017

I think we can just remove debugShowStatistics and debugShowPickStatistics, expose a @private getter for _statistics, and then basically move the showStats logic to the inspector.

See how it feels.

@austinEng austinEng mentioned this issue Jan 17, 2017
4 tasks
@pjcozzi pjcozzi closed this as completed Feb 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants