Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up CZML custom properties demo #5704

Closed
3 tasks
hpinkos opened this issue Jul 31, 2017 · 0 comments
Closed
3 tasks

Clean up CZML custom properties demo #5704

hpinkos opened this issue Jul 31, 2017 · 0 comments
Labels
category - sandcastle good first issue An opportunity for first time contributors

Comments

@hpinkos
Copy link
Contributor

hpinkos commented Jul 31, 2017

It took me way too long to figure out what this example was trying to demonstrate

http://cesiumjs.org/Cesium/Apps/Sandcastle/index.html?src=CZML%20Custom%20Properties.html&label=All

  • Get rid of the Print values button. I don't think it is particularly useful. If it is important to see the values, it would be better to display them on screen in a label.
  • Replace the Use interval data and Use sampled data buttons with a combobox that switches between the two options. Right now neither is seleted by default so nothing is happening as the timeline is scrubbing until you select one of the options
  • Change the data to something that is more of a dramatic change. It looks like we were trying to use a real world example, but there is barely enough of a change to see the height of the polygon change. Either represent something different, or replace the PA polygon with an arbitrary polygon with arbitrary height values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category - sandcastle good first issue An opportunity for first time contributors
Projects
None yet
Development

No branches or pull requests

1 participant