You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As mentioned in #7140Resource._Implementations.loadAndExecuteScript could be simplified to not take a deferred. It also currently takes a functionName parameter that isn't used.
While this is an easy change to make, the problem is that the tests really abuse Resource._Implementations.loadAndExecuteScript for mocking and cleaning up the code means the tests all have to be updated, which may not be too much work but requires fully understanding what's going on in them.
The text was updated successfully, but these errors were encountered:
As mentioned in #7140
Resource._Implementations.loadAndExecuteScript
could be simplified to not take adeferred
. It also currently takes afunctionName
parameter that isn't used.While this is an easy change to make, the problem is that the tests really abuse
Resource._Implementations.loadAndExecuteScript
for mocking and cleaning up the code means the tests all have to be updated, which may not be too much work but requires fully understanding what's going on in them.The text was updated successfully, but these errors were encountered: