Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Resource._Implementations.loadAndExecuteScript #7141

Open
mramato opened this issue Oct 11, 2018 · 0 comments
Open

Remove Resource._Implementations.loadAndExecuteScript #7141

mramato opened this issue Oct 11, 2018 · 0 comments
Labels

Comments

@mramato
Copy link
Contributor

mramato commented Oct 11, 2018

As mentioned in #7140 Resource._Implementations.loadAndExecuteScript could be simplified to not take a deferred. It also currently takes a functionName parameter that isn't used.

While this is an easy change to make, the problem is that the tests really abuse Resource._Implementations.loadAndExecuteScript for mocking and cleaning up the code means the tests all have to be updated, which may not be too much work but requires fully understanding what's going on in them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant