Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KHR_materials_common test failure in master #7205

Closed
OmarShehata opened this issue Oct 30, 2018 · 1 comment · Fixed by #7206
Closed

KHR_materials_common test failure in master #7205

OmarShehata opened this issue Oct 30, 2018 · 1 comment · Fixed by #7206

Comments

@OmarShehata
Copy link
Contributor

This test is failing in master:

 Scene/Model
    × loads a glTF with KHR_materials_common using a black ambient/directional light
        Expected to render [51,51,51,255], but actually rendered [61,61,61,255].
            at <Jasmine>
            at Specs/Scene/ModelSpec.js:2083:27
            at Promise.then (Source/ThirdParty/when.js:196:34)
            at Source/ThirdParty/when.js:297:13
            at processQueue (Source/ThirdParty/when.js:647:4)

I haven't investigated if it's just a matter of adding an epsilon or if this is something that has broken.
@OmarShehata OmarShehata mentioned this issue Oct 30, 2018
Merged
@lilleyse
Copy link
Contributor

It looks like this requires a gltf-pipeline fix. Empty nodes containing light extensions are being removed. I'm looking into it.

This was referenced Oct 30, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update gltf-pipeline and fix model test CesiumGS/cesium
2 participants
@lilleyse @OmarShehata