Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify model caching #7801

Closed
lilleyse opened this issue May 1, 2019 · 1 comment
Closed

Simplify model caching #7801

lilleyse opened this issue May 1, 2019 · 1 comment
Labels

Comments

@lilleyse
Copy link
Contributor

lilleyse commented May 1, 2019

Model.js has a global glTF json cache and a per-context WebGL resources cache. To help simplify the code we might want to consider using the per-context cache for everything. Some other things that could make the code easier to follow and less bug prone would be:

But mainly I think the area just needs some cleanup, as it probably started out simple but has gotten more complex as glTF 2.0 and 3D Tiles happened.

@j9liu
Copy link
Contributor

j9liu commented Aug 19, 2022

@lilleyse can this issue be closed now that ModelExperimental has replaced Model ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants