Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is the clipping plane different from the actual cut #8053

Closed
PrUnSt opened this issue Aug 12, 2019 · 5 comments · Fixed by #8555
Closed

Why is the clipping plane different from the actual cut #8053

PrUnSt opened this issue Aug 12, 2019 · 5 comments · Fixed by #8555

Comments

@PrUnSt
Copy link

PrUnSt commented Aug 12, 2019

Sandcastle example: https://cesiumjs.org/Cesium/Build/Apps/Sandcastle/?src=3D%20Tiles%20Clipping%20Planes.html

Browser: chrome 73.0.3683.86

Operating System: windows10

image

@OmarShehata
Copy link
Contributor

I need to investigate a bit more to determine if the issue is in this tileset or not. It may be related to how we changed how we compute the origin point for the clipping planes: #7182.

Have you encountered this on your own tilesets, or just on this one?

For anyone else looking at this, it becomes much more obvious when you set the alpha of the clipping plane to 0.7 or 0.8, it's clear that there's a discrepancy between the clipping plane itself, and the visual plane entity.

@PrUnSt
Copy link
Author

PrUnSt commented Aug 13, 2019

I have encountered this problem on many tileset

@likangning93
Copy link
Contributor

It may be related to how we changed how we compute the origin point for the clipping planes

More supporting evidence, there doesn't seem to be a noticeable offset when clipping individual models or terrain.

@PrUnSt
Copy link
Author

PrUnSt commented Aug 30, 2019

how cesium compute the origin point for the clipping planes:

@OmarShehata
Copy link
Contributor

Just an update that I believe this is fixed in this draft PR: #8392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants