Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

deprecate dapp test in dappeteer #192

Closed
BeroBurny opened this issue Nov 22, 2022 · 0 comments
Closed

deprecate dapp test in dappeteer #192

BeroBurny opened this issue Nov 22, 2022 · 0 comments
Assignees

Comments

@BeroBurny
Copy link
Contributor

BeroBurny commented Nov 22, 2022

Deprecate dappeteer testing dapp in favor of using evaluate method.

do you thing we could start writing tests without adding code to test dapp like:

const resultPromise  = testPage.evaluate(async function() {
   //prepare data
   return window.ethereum.sendAsync(
      {
        method,
        params,
        from: accounts[0],
      });
});
await dappteer.signTypedData()
const result = await resultPromise

Originally posted by @mpetrunic in #191 (comment)

@Tbaut Tbaut self-assigned this Nov 22, 2022
@Tbaut Tbaut closed this as completed Dec 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants