Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

chore: refactor to remove braking change #242

Merged
merged 1 commit into from
Jan 16, 2023
Merged

chore: refactor to remove braking change #242

merged 1 commit into from
Jan 16, 2023

Conversation

BeroBurny
Copy link
Contributor

Short description of work done

PR Checklist

  • I have run linter locally
  • I have run unit and integration tests locally
    • Update configuration the newest version (readme and const)
  • Rebased to master branch / merged master

Changes

  • EXAMPLE - Removed basic auth from the controller

Issues

Closes #

@BeroBurny BeroBurny self-assigned this Jan 16, 2023
mpetrunic
mpetrunic suggested changes Jan 16, 2023
View reviewed changes
Copy link
Member

@mpetrunic mpetrunic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are trying to remove #241

@BeroBurny
Copy link
Contributor Author

You are trying to remove #241

it is moved into the setup

dappeteer/src/setup/playwright.ts

Line 24 in b6e89e2

"--accept-lang=en",

dappeteer/src/setup/puppeteer.ts

Line 14 in b6e89e2

"--accept-lang=en",

@BeroBurny BeroBurny merged commit 6434c83 into master Jan 16, 2023
@BeroBurny BeroBurny deleted the beroburny/unbrake-changes branch January 16, 2023 15:01
This was referenced Jan 16, 2023
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mpetrunic mpetrunic mpetrunic approved these changes

@Lykhoyda Lykhoyda Awaiting requested review from Lykhoyda Lykhoyda is a code owner

@irubido irubido Awaiting requested review from irubido irubido is a code owner

Assignees

@BeroBurny BeroBurny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BeroBurny @mpetrunic