Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Reminder to remove flag from flask test #269

Closed
Lykhoyda opened this issue Feb 3, 2023 · 0 comments · Fixed by #281
Closed

Reminder to remove flag from flask test #269

Lykhoyda opened this issue Feb 3, 2023 · 0 comments · Fixed by #281
Labels
bug Something isn't working

Comments

@Lykhoyda
Copy link
Contributor

Lykhoyda commented Feb 3, 2023

Describe the bug
The test "should not add network" is skipped in the Flask version due to the error in the latest metamask update (v10.24.0). The bug is reported to the metamask team. We need to remove the check to skip the test in the flask once it will be fixed in the future version.

To Reproduce
Steps to reproduce the behavior:
Run tests with flask v10.24.x and remove the flag in "should not add network"

if (this.browser.isMetaMaskFlask()) {
      this.skip();
    }

Screenshots
If applicable, add screenshots to help explain your problem.
Screenshot 2023-02-02 at 14 57 10

@Lykhoyda Lykhoyda added the bug Something isn't working label Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant