Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ban std::env::var, and have one ForestVars structure #4182

Open
aatifsyed opened this issue Apr 11, 2024 · 0 comments
Open

ban std::env::var, and have one ForestVars structure #4182

aatifsyed opened this issue Apr 11, 2024 · 0 comments
Labels
Priority: 4 - Low Limited impact and can be implemented at any time

Comments

@aatifsyed
Copy link
Contributor

  • We should have one struct where forest environment variables are described (for end users) and accessed (in code)
  • Remove documentation/src/environment_variables.md, and have it link to the rustdoc for the above

These means we have:

  • better control over environment variables
  • documentation that stays up-to-date

We could also have an approach like #3370 or using https://docs.rs/figment/latest/figment/index.html for config

Cargo did something similar last year: rust-lang/cargo#11588

Originally posted by @aatifsyed in #4177 (comment)

@aatifsyed aatifsyed mentioned this issue Apr 11, 2024
4 tasks
@lemmih lemmih added the Priority: 4 - Low Limited impact and can be implemented at any time label Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 4 - Low Limited impact and can be implemented at any time
Projects
None yet
Development

No branches or pull requests

2 participants