From 665a370a353101987770983112f4a2bccb1ec4dd Mon Sep 17 00:00:00 2001 From: Timothy Wu Date: Fri, 4 Oct 2024 13:34:02 -0400 Subject: [PATCH] cr feedback, code cleanup --- .gitignore | 2 +- pkg/trie/triedb/child_tries.go | 21 --------------------- pkg/trie/triedb/node.go | 1 - 3 files changed, 1 insertion(+), 23 deletions(-) delete mode 100644 pkg/trie/triedb/child_tries.go diff --git a/.gitignore b/.gitignore index 97bdb42e7d..2153416fe9 100644 --- a/.gitignore +++ b/.gitignore @@ -29,4 +29,4 @@ tests/polkadotjs_test/node_modules !tests/polkadotjs_test/test/*.wasm # mac specific -.DS_Store +.DS_Store \ No newline at end of file diff --git a/pkg/trie/triedb/child_tries.go b/pkg/trie/triedb/child_tries.go deleted file mode 100644 index 7fed221173..0000000000 --- a/pkg/trie/triedb/child_tries.go +++ /dev/null @@ -1,21 +0,0 @@ -// Copyright 2024 ChainSafe Systems (ON) -// SPDX-License-Identifier: LGPL-3.0-only - -package triedb - -import ( - "github.com/ChainSafe/gossamer/lib/common" - "github.com/ChainSafe/gossamer/pkg/trie" -) - -func (t *TrieDB[H, Hasher]) GetChild(keyToChild []byte) (trie.Trie, error) { - panic("not implemented yet") -} - -func (t *TrieDB[H, Hasher]) GetFromChild(keyToChild, key []byte) ([]byte, error) { - panic("not implemented yet") -} - -func (t *TrieDB[H, Hasher]) GetChildTries() map[common.Hash]trie.Trie { - panic("not implemented yet") -} diff --git a/pkg/trie/triedb/node.go b/pkg/trie/triedb/node.go index 75fee86332..e9ad1808b4 100644 --- a/pkg/trie/triedb/node.go +++ b/pkg/trie/triedb/node.go @@ -54,7 +54,6 @@ func newEncodedValue[H hash.Hash]( // Check and get new new value hash switch cr := childRef.(type) { case HashChildReference[H]: - // if bytes.Equal(cr, common.EmptyHash.ToBytes()) { empty := *new(H) if cr.Hash == empty { panic("new external value are always added before encoding a node")