Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(logs): remove function name prefix in logs in runtime packages #2052

Closed
qdm12 opened this issue Nov 19, 2021 · 0 comments · Fixed by #2110
Closed

chore(logs): remove function name prefix in logs in runtime packages #2052

qdm12 opened this issue Nov 19, 2021 · 0 comments · Fixed by #2110
Assignees

Comments

@qdm12
Copy link
Contributor

qdm12 commented Nov 19, 2021

Task summary

This concerns the lib/runtime/wasmer and lib/runtime/life packages.

Since the logger logs the calling function, and that we named our functions as defined in the spec (e.g. ext_offchain_http_request_add_header_version_1), we should remove the function name prefix we manually add for all logs in those packages.

In example:

logger.Debug("[ext_offchain_http_request_add_header_version_1] executing...")

to

logger.Debug("executing...")

You can probably just use a regex like \("[ext_.+] and replace all with (".

💁 This would unclutter logs for users and make code cleaner for developers.

Originally discussed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants