Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GRANDPA Should Only Process Forced Changes When They Exist (GSR-12) #2349

Closed
danforbes opened this issue Mar 4, 2022 · 1 comment · Fixed by #2519
Closed

GRANDPA Should Only Process Forced Changes When They Exist (GSR-12) #2349

danforbes opened this issue Mar 4, 2022 · 1 comment · Fixed by #2519
Assignees
@EclesioMeloJunior

Comments

@danforbes
Copy link
Contributor

danforbes commented Mar 4, 2022 •
edited
Loading

Gossamer should ignore scheduled changes when forced changes exist. In Substrate they will only process the forced change and ignore the scheduled changes. However in Gossamer both the scheduled change and forced change will be processed, which is incorrect behavior.
@danforbes danforbes changed the title GRANDPA Should Only Process Forced Changes When They Exist GRANDPA Should Only Process Forced Changes When They Exist (GSR-12) Mar 21, 2022
@danforbes
Copy link
Contributor Author

Will be closed by #2519

@danforbes danforbes linked a pull request Jun 13, 2022 that will close this issue
fix(state/grandpa): track changes across forks #2519
Merged
1 task
@EclesioMeloJunior EclesioMeloJunior mentioned this issue Jun 13, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EclesioMeloJunior EclesioMeloJunior

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(state/grandpa): track changes across forks ChainSafe/gossamer
2 participants
@danforbes @EclesioMeloJunior