Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/babe: Rewrite skipped tests to correctly use westend #3060

Closed
7 tasks done
jimjbrettj opened this issue Jan 23, 2023 · 1 comment
Closed
7 tasks done

lib/babe: Rewrite skipped tests to correctly use westend #3060

jimjbrettj opened this issue Jan 23, 2023 · 1 comment
Assignees
@jimjbrettj

Comments

@jimjbrettj
Copy link
Contributor

jimjbrettj commented Jan 23, 2023 •
edited
Loading

Issue summary

  • Some of the integration tests in babe were not designed to be run on westend, so this PR is to rewrite and fix those tests
  • General cleanup of babe integration tests if I see points of improvement
  • Add comments to complicated tests to make them easier to follow
  • Rename tests to be more descriptive when appropriate
  • Remove usage of time.Now() to make timestamps more intentional and tests stable
  • There is a weird relationship between the passed-in config data and the VerificationManager that should be cleaned up if possible

Tests that need work are:

  • TestService_HandleSlotWithSameSlot
  • TestService_HandleSlotWithLaggingSlot
  • TestBuildBlock_ok
  • TestBuildBlock_failing
  • TestVerificationManager_VerifyBlock_Secondary
  • TestVerificationManager_VerifyBlock_MultipleEpochs
  • TestVerificationManager_VerifyBlock_InvalidBlockOverThreshold

Other information and links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jimjbrettj jimjbrettj

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jimjbrettj