opts.gossipIncoming does nothing?

[achingbrain]

When it was added there was a conditional that checked the value of opts.gossipIncoming and didn't gossip incoming messages when it was false.

Now that this module has been refactored to not extend the base pubsub class in @libp2p/pubsub nothing seems to use that init option.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

[achingbrain]

Still does nothing AFAICS

[twoeths]

gossipIncoming option is used to forward messages to FloodSub peers and mesh peers, which is the default behavior right now.

I don't see this option in rust's implementation, @wemeetagain do we need this option for any applications? If not I think we can just delete this option.

[wemeetagain]

yeah, its stale code, should be deleted