Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: commit package-lock.json #359

Merged
merged 1 commit into from
Oct 18, 2022
Merged

chore: commit package-lock.json #359

merged 1 commit into from
Oct 18, 2022

Conversation

dapplion
Copy link
Contributor

@dapplion dapplion commented Oct 7, 2022 •
edited
Loading

CI must be determistic, not committing a lock file breaks this invariant.

To ensure that this package is install-able a cron CI job that just builds the package would be enough

@dapplion dapplion requested a review from a team as a code owner October 7, 2022 15:35
@dapplion dapplion changed the title Commit package-lock.json chore: commit package-lock.json Oct 7, 2022
@wemeetagain wemeetagain mentioned this pull request Oct 18, 2022
Closed
@wemeetagain wemeetagain merged commit eb1a145 into master Oct 18, 2022
@wemeetagain wemeetagain deleted the dapplion/package-lock branch October 18, 2022 14:54
@github-actions github-actions bot mentioned this pull request Oct 18, 2022
Merged
@dapplion dapplion mentioned this pull request Oct 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dapplion @wemeetagain