Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not bound GossipPubSub results in "addIP" being undefined #373

Closed
oleksiyp opened this issue Nov 14, 2022 · 0 comments · Fixed by #374
Closed

Not bound GossipPubSub results in "addIP" being undefined #373

oleksiyp opened this issue Nov 14, 2022 · 0 comments · Fixed by #374

Comments

@oleksiyp
Copy link

Hi! 👋

Firstly, thanks for your work on this project! 🙂

Today I used patch-package to patch @chainsafe/libp2p-gossipsub@5.2.0 for the project I'm working on.

During run I faced an issue of "addIP" being undefined. This is a result of this.onPeerAddressChange not being bound to a GossipPubSub.

Here is the diff that solved my problem:

diff --git a/node_modules/@chainsafe/libp2p-gossipsub/dist/src/index.js b/node_modules/@chainsafe/libp2p-gossipsub/dist/src/index.js
index adbc229..9e445b9 100644
--- a/node_modules/@chainsafe/libp2p-gossipsub/dist/src/index.js
+++ b/node_modules/@chainsafe/libp2p-gossipsub/dist/src/index.js
@@ -296,7 +296,7 @@ export class GossipSub extends EventEmitter {
         // Schedule to start heartbeat after `GossipsubHeartbeatInitialDelay`
         const heartbeatTimeout = setTimeout(this.runHeartbeat, constants.GossipsubHeartbeatInitialDelay);
         // Then, run heartbeat every `heartbeatInterval` offset by `GossipsubHeartbeatInitialDelay`
-        this.components.peerStore.addEventListener('change:multiaddrs', this.onPeerAddressChange);
+        this.components.peerStore.addEventListener('change:multiaddrs', this.onPeerAddressChange.bind(this));
         this.status = {
             code: GossipStatusCode.started,
             registrarTopologyIds,

This issue body was partially generated by patch-package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant