Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webpack bundle too large #27

Closed
mpetrunic opened this issue Feb 7, 2020 · 4 comments
Closed

Webpack bundle too large #27

mpetrunic opened this issue Feb 7, 2020 · 4 comments

Comments

@mpetrunic
Copy link
Member

  • bcrypto is using "import" instead of require which pull entire bcrypto lib and adds ~1.2 Mb to webpack bundle
@mpetrunic
Copy link
Member Author

@morrigan
Copy link
Member

Reduced to 681kB - https://bundlephobia.com/result?p=libp2p-noise@1.1.0
Not great, not terrible.

Closing in favor that libp2p-crypto will it's reduce size.

@jacobheun
Copy link
Collaborator

Just FYI, I am working on downstream integration of this in js-ipfs, ipfs/js-ipfs#3004. The bundlesize change there is only around 73KB. Not great, but not as much as I was expecting. I'll be working on this over the next few weeks and will submit any updates here as I find them.

libp2p-crypto will it's reduce size

I am planning on making libp2p-crypto composable to make reducing the size easier, but likely won't get to that until around July.

@mpetrunic
Copy link
Member Author

Would be nice if you added x25519, aead(chacha-poly) and hkdf support, we tried swapping those but none of the x25519 alternatives worked in interop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants