Add fork choice tests

[wemeetagain]

Is your feature request related to a problem? Please describe.
A more rigorous fork choice test suite may uncover lurking bugs and provide us more confidence of the correctness of our code.

Describe the solution you'd like
Add the tests found here: ethereum/consensus-spec-tests#17
to the spec-tests package so they may be run along with other spec tests in CI

[twoeths]

waiting for the tests to be merged to the official eth2.0-spec-tests npm package

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

[dapplion]

unstale

[dapplion]

waiting for the tests to be merged to the official eth2.0-spec-tests npm package

@tuyennhv have those been merged already?

[twoeths]

@dapplion it's not officially merged yet, still in some personal branches

[dapplion]

@dapplion it's not officially merged yet, still in some personal branches

@tuyennhv Could you link those branches here to track them?

[twoeths]

They stay in https://github.com/txrx-research/eth2.0-spec-tests/tree/fork_choice_integration_tests_v012_2/tests/minimal/phase0/fork_choice/integration_tests and https://github.com/txrx-research/eth2.0-spec-tests/tree/fork_choice_integration_tests_v012_2_optional_checks/tests/minimal/phase0/fork_choice/integration_tests

I'm not sure the difference between them.

[dapplion]

Thanks! Are other clients using this tests?

[twoeths]

I'm not sure but guess they not yet to do since it hasn't become official yet

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

[3xtr4t3rr3str14l]

unstale

[dapplion]

I'm not sure but guess they not yet to do since it hasn't become official yet

@tuyennhv What's the current status?

[twoeths]

I'm not sure but guess they not yet to do since it hasn't become official yet

@tuyennhv What's the current status?

it's still not merged to the official spec tests

[twoeths]

so after ethereum/consensus-specs#2202 , get_head test format is available at https://github.com/ethereum/eth2.0-specs/tree/master/tests/formats/fork_choice

still don't see the tests in eth2.0-spec-tests repository.

[wemeetagain]

fork choice tests should now be available in our downloaded tests with the update to v1.1.0-alpha.3 💯

[dapplion]

Close after adding specs for Altair. Are those ready @tuyennhv ?

[twoeths]

@dapplion I think we do have forkchoice spec for merge but not for altair

[wemeetagain]

altair and phase0 fork choice tests are currently merged 👍