Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PROD] Validator miss attestation #3527

Closed
twoeths opened this issue Dec 16, 2021 · 8 comments
Closed

[PROD] Validator miss attestation #3527

twoeths opened this issue Dec 16, 2021 · 8 comments
Assignees
Labels
scope-performance Performance issue and ideas to improve performance. scope-profitability Issues to directly improve validator performance and its profitability.

Comments

@twoeths
Copy link
Contributor

twoeths commented Dec 16, 2021

Describe the bug

Validator 270069 missed an attestation at slot 2733664. For more information visit: https://beaconcha.in/validator/270069

Expected behavior

Validator should not miss any attestations

@twoeths
Copy link
Contributor Author

twoeths commented Dec 16, 2021

Validator log shows that the attestation is published on time with correct head

Dec-16 04:13:14.649 []                ^[[34mdebug^[[39m: Signed attestation slot=2733664, index=27, head=0xeb5d6fccd8d86989f576e83b22bac72de531abb858a2314e7283a3bce9b3b17f, validatorIndex=270069

committeesPerSlot = 131, epoch slot = 0, committee index = 27 => attestation subnet = 27

Node log shows that attestation is published by gossipsub

Dec-16 04:13:11.010 [CHAIN]         ^[[36mverbose^[[39m: Clock slot slot=2733664
Dec-16 04:13:14.651 [API]             ^[[34mdebug^[[39m: Req req-6gh 127.0.0.1 POST:/eth/v1/beacon/pool/attestations
Dec-16 04:13:14.770 [NETWORK]       ^[[36mverbose^[[39m: Publish to topic topic=/eth2/afcaaba0/beacon_attestation_27/ssz_snappy

maybe it's an issue of having attestation subnet 27 peers at that time to spread the attestation to the network

Screen Shot 2021-12-16 at 11 50 36

@dapplion
Copy link
Contributor

@tuyennhv We should have some internal log of an attestation's journey.

  1. Submitted by validator
  2. Received in some aggregate
  3. Received in block

@twoeths
Copy link
Contributor Author

twoeths commented Jan 13, 2022

one reason could be we submit attestation too early sigp/lighthouse#635 (comment) , and the other peer (could be another lodestar node) ignore the attestation since they haven't seen the voted block

@dapplion
Copy link
Contributor

one reason could be we submit attestation too early sigp/lighthouse#635 (comment) , and the other peer (could be another lodestar node) ignore the attestation since they haven't seen the voted block

That seems extremely unlikely, there are multiple aggregators per subnet and Lodestar represents a tiny fraction of the network

@twoeths
Copy link
Contributor Author

twoeths commented Jan 14, 2022

one reason could be we submit attestation too early sigp/lighthouse#635 (comment) , and the other peer (could be another lodestar node) ignore the attestation since they haven't seen the voted block

That seems extremely unlikely, there are multiple aggregators per subnet and Lodestar represents a tiny fraction of the network

I mean if the original node only propagate subnet attestation to the other lodestar node and that lodestar node just ignore the subnet attestation (since it does not know the root), no aggregator could include it and it becomes missed

@dapplion
Copy link
Contributor

@tuyennhv Nimbus latest release specifically optimize for situations where emitting to no peers:

Tuned peer management: reduces the likelihood of missed attestations

If you've seen frequent "No peers for topic" in your logs, this release will help

https://github.com/status-im/nimbus-eth2/releases/tag/v1.6.0

You should investigate what they've changed or reach out

@philknows philknows added the scope-performance Performance issue and ideas to improve performance. label Jan 24, 2022
@twoeths
Copy link
Contributor Author

twoeths commented Feb 24, 2022

#3781 helps us gain good gossip peer score, hence more mesh peers. This could help us mitigate the issue.

@dapplion dapplion added the scope-profitability Issues to directly improve validator performance and its profitability. label May 10, 2022
@twoeths
Copy link
Contributor Author

twoeths commented May 23, 2022

There were a lot of enhancements/improvements since I open the issue, we rarely missed attestations in the last 7 days

Screen Shot 2022-05-23 at 10 28 19

the known issues were resolved so closing the issue for now, we should open new issues for any specific missed attesttations

@twoeths twoeths closed this as completed May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope-performance Performance issue and ideas to improve performance. scope-profitability Issues to directly improve validator performance and its profitability.
Projects
None yet
Development

No branches or pull requests

3 participants