Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing and calling prepare_beacon_proposer and providing suggestedFeeRecipient to the BN #3693

Closed
g11tech opened this issue Feb 4, 2022 · 1 comment · Fixed by #3958
Closed

Implementing and calling prepare_beacon_proposer and providing suggestedFeeRecipient to the BN #3693

g11tech opened this issue Feb 4, 2022 · 1 comment · Fixed by #3958
Assignees
@g11tech
Labels
spec-bellatrix 🐼 Issues targeting the merge spec version.

Comments

@g11tech
Copy link
Contributor

g11tech commented Feb 4, 2022

Beacon node needs to provide suggestedFeeRecipient which could be a validator specific field. Since timing preparePayload could be an independent operation from produceBlock api call by the validator, the BN needs to be aware.

How this can be achieved is in a bit of flux with the debate over if its Beacon/Validator driven. A prepare_beacon_proposer endpoint has been suggested for the same.. However some issues/race conditions have come up(ethereum/beacon-APIs#187)

Track and discuss how to best implement this in lodestar.
@g11tech g11tech self-assigned this Feb 4, 2022
@g11tech g11tech changed the title Providing suggestedFeeRecipient to the BN for prepare payload FcU call Providing suggestedFeeRecipient to the BN for prepare payload fcU call Feb 4, 2022
@g11tech g11tech mentioned this issue Mar 1, 2022
Closed
@philknows philknows mentioned this issue Mar 4, 2022
Closed
@philknows
Copy link
Member

Leaving a reference here for the current two implementations by Lighthouse and Teku:

Teku implementation: Consensys/teku#4894
Lighthouse implementation: sigp/lighthouse#2924

@g11tech g11tech mentioned this issue Apr 22, 2022
Closed
22 tasks
@g11tech g11tech changed the title Providing suggestedFeeRecipient to the BN for prepare payload fcU call Implementing and calling prepare_beacon_proposer and providing suggestedFeeRecipient to the BN Apr 22, 2022
@g11tech g11tech mentioned this issue Apr 28, 2022
Merged
3 tasks
@dapplion dapplion added the spec-bellatrix 🐼 Issues targeting the merge spec version. label May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@g11tech g11tech

Labels
spec-bellatrix 🐼 Issues targeting the merge spec version.
Projects
None yet
Milestone
No milestone
3 participants
@dapplion @philknows @g11tech