Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.2.0: isIP and isIPv4 performance issue #4689

Closed
twoeths opened this issue Oct 25, 2022 · 2 comments · Fixed by #4713
Closed

v1.2.0: isIP and isIPv4 performance issue #4689

twoeths opened this issue Oct 25, 2022 · 2 comments · Fixed by #4713
Assignees
@wemeetagain
Labels
prio-high Resolve issues as soon as possible. scope-performance Performance issue and ideas to improve performance.
Milestone
v1.2.0

Comments

@twoeths
Copy link
Contributor

twoeths commented Oct 25, 2022 •
edited by wemeetagain
Loading

Describe the bug

this is from a node with novc running v1.2.0

Screen Shot 2022-10-25 at 20 35 43

1025_as_chacha20poly1305_novc.cpuprofile.zip

Expected behavior

with v1.1.1, it almost takes 0% cpu time there

1025_v1.1.1_sm1v.cpuprofile.zip
@wemeetagain
Copy link
Member

Difference is that newer versions of is-ip package uses the super-regex which is way overkill and adds a lot of overhead.

We probably want to revert multiformats/js-multiaddr#260

@wemeetagain wemeetagain mentioned this issue Oct 25, 2022
Merged
@achingbrain achingbrain mentioned this issue Oct 25, 2022
Open
@philknows philknows added this to the v1.2.0 milestone Oct 26, 2022
@philknows philknows added prio-high Resolve issues as soon as possible. scope-performance Performance issue and ideas to improve performance. labels Oct 26, 2022
@twoeths twoeths mentioned this issue Oct 27, 2022
Closed
@wemeetagain
Copy link
Member

See ChainSafe/is-ip#1

This was referenced Oct 29, 2022
Closed
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wemeetagain wemeetagain

Labels
prio-high Resolve issues as soon as possible. scope-performance Performance issue and ideas to improve performance.
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging a pull request may close this issue.

Update multiaddr ChainSafe/lodestar
3 participants
@wemeetagain @twoeths @philknows