Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support eventstream example (light_client_*_update) from recent beacon API test suite #6170

Closed
jeluard opened this issue Dec 8, 2023 · 0 comments · Fixed by #6354
Closed
Labels
scope-testing Issues for adding test coverage, fixing existing tests or testing strategies.

Comments

@jeluard
Copy link
Contributor

jeluard commented Dec 8, 2023

Beacon APIs v2.4.0 introduce new eventstream examples #1 and #2 that do not pass currently on lodestar.

  1) eventstream event data
       light_client_finality_update:
     Error: Invalid slot=0 fork=phase0 for lightclient fork types
      at Object.getLightClientForkTypes (file:///Users/julien/Documents/Projects/chainsafe/lodestar/packages/config/lib/forkConfig/index.js:95:23)
      at getLightClientTypeFromHeader (file:///Users/julien/Documents/Projects/chainsafe/lodestar/packages/api/src/beacon/routes/events.ts:71:23)
      at Object.toJson (file:///Users/julien/Documents/Projects/chainsafe/lodestar/packages/api/src/beacon/routes/events.ts:117:31)
      at Object.toJson (file:///Users/julien/Documents/Projects/chainsafe/lodestar/packages/api/src/beacon/routes/events.ts:136:30)
      at Context.<anonymous> (file:///Users/julien/Documents/Projects/chainsafe/lodestar/packages/api/test/unit/beacon/oapiSpec.test.ts:174:47)
      at process.processImmediate (node:internal/timers:478:21)
@jeluard jeluard added the scope-testing Issues for adding test coverage, fixing existing tests or testing strategies. label Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope-testing Issues for adding test coverage, fixing existing tests or testing strategies.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant