Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Tests: Fix false test failure due to multiple elements #1119

Closed
asnaith opened this issue Jun 10, 2021 · 2 comments
Closed

UI Tests: Fix false test failure due to multiple elements #1119

asnaith opened this issue Jun 10, 2021 · 2 comments
Assignees
Labels
Issue: Bug 🐛 Added to issues relating to a critical severity bugs. Testing Added to issues to signal that it is part of an epic

Comments

@asnaith
Copy link
Member

asnaith commented Jun 10, 2021

We recently saw an issue in CI where the test failed because cypress detected multiple elements on the screen, only expected 1, and then failed because it didn't know which one to click.

File management -- desktop -- can rename a file with error handling (failed)

Acceptance criteria

  • Test does not fail falsely due to multiple elements being found
@asnaith asnaith added the Testing Added to issues to signal that it is part of an epic label Jun 10, 2021
@asnaith asnaith self-assigned this Jun 10, 2021
@Tbaut
Copy link
Collaborator

Tbaut commented Jun 10, 2021

ah nice, a race condition with the "upload completed" right?

@Tbaut Tbaut added the Issue: Bug 🐛 Added to issues relating to a critical severity bugs. label Jun 10, 2021
@asnaith
Copy link
Member Author

asnaith commented Jun 10, 2021

ah nice, a race condition with the "upload completed" right?

@Tbaut Yeah, I think so. It doesn't look like there are multiple rename menu elements but I think the toast overlapping it is confusing cypress. I will experiment with adding a custom tag to the toast and waiting to ensure that it's not present before clicking the kebab menu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Bug 🐛 Added to issues relating to a critical severity bugs. Testing Added to issues to signal that it is part of an epic
Projects
None yet
Development

No branches or pull requests

2 participants