Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join share by opening a shared folder invite link #1474

Closed
FSM1 opened this issue Aug 25, 2021 · 6 comments
Closed

Join share by opening a shared folder invite link #1474

FSM1 opened this issue Aug 25, 2021 · 6 comments
Labels
Epic: Sharing with link Added to issues due for Sharing v1, allowing to share with any email from Google/Github. Planning: Needs Design 🖼️ This UI component still needs one more designs to complete

Comments

@FSM1
Copy link
Contributor

FSM1 commented Aug 25, 2021

A user who receives this link (after login) is directed to a page that will parse this link, extract the encryption key, encrypt the key with their pubKey.

In the event of a user not being logged in the login page should notify the user that they need to log in to access the shared content.

This page will then make an API request presenting the encryptedEncryptionKey, and the JWT.

The API will validate the JWT, make sure it was signed by the Shared Folder owner, and if all this info matches up, then the user making the request is added to the share.

The app would redirect the user to /shared/{bucketId}/

@FSM1 FSM1 added Epic: Sharing with link Added to issues due for Sharing v1, allowing to share with any email from Google/Github. Planning: Needs Design 🖼️ This UI component still needs one more designs to complete Planning: Needs estimation Priority: P3 Low Added to issues relating to a low severity bugs. labels Aug 25, 2021
@FSM1
Copy link
Contributor Author

FSM1 commented Sep 15, 2021

Hey team! Please add your planning poker estimate with ZenHub @RyRy79261 @tanmoyAtb @Tbaut

@sweetpea22
Copy link
Contributor

So if i'm getting this right, under all circumstances a user must create a files account to view content from a shared link. And this is considered technically publicly accessible as long as the user has a files account. Is that correct?

@FSM1
Copy link
Contributor Author

FSM1 commented Sep 25, 2021

Thats right - the link is an "permission slip" to our backend instructing it to add the bearer to the list of readers/writers of a particular bucket. Before this token can be utilized a user needs to have a key pair associated with their credentials, which can only happen after registration.

@sweetpea22
Copy link
Contributor

Text content is changed on the auth screen, and redirects to folder once sign up/sign in is completed, I assume
Screen Shot 2021-10-06 at 9 51 41 AM

@Tbaut
Copy link
Collaborator

Tbaut commented Oct 7, 2021

Not sure what we want to show once we passed the login, maybe a dedicated page with a loader "you're being added to XYZ"
And then "success" with a link to the shared folder?

@Tbaut Tbaut removed the Priority: P3 Low Added to issues relating to a low severity bugs. label Oct 7, 2021
@FSM1
Copy link
Contributor Author

FSM1 commented Nov 8, 2021

Closed in #1620

@FSM1 FSM1 closed this as completed Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic: Sharing with link Added to issues due for Sharing v1, allowing to share with any email from Google/Github. Planning: Needs Design 🖼️ This UI component still needs one more designs to complete
Projects
None yet
Development

No branches or pull requests

3 participants