Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make link creation design nicer #1630

Closed
Tbaut opened this issue Oct 14, 2021 · 5 comments · Fixed by #1722
Closed

Make link creation design nicer #1630

Tbaut opened this issue Oct 14, 2021 · 5 comments · Fixed by #1722
Assignees
@Tbaut
Labels
Epic: Sharing with link Added to issues due for Sharing v1, allowing to share with any email from Google/Github. Product: Files

Comments

@Tbaut
Copy link
Collaborator

Tbaut commented Oct 14, 2021 •
edited
Loading

I came up with this design, it's not ideal I guess. Let's brainstorm and find its flaws and come up with something better

Some comments from @tanmoyAtb

This one is about preference, I would like to have the Create new Link button on the right side of permissions dropdown, feels more natural to me. (I haven't seen the designs though).

I guess my buttons are just too big?

link-sharing.mp4
@Tbaut Tbaut added Planning: Needs Design 🖼️ This UI component still needs one more designs to complete Epic: Sharing with link Added to issues due for Sharing v1, allowing to share with any email from Google/Github. Planning: Needs estimation Product: Files labels Oct 14, 2021
@alexmmueller
Copy link
Member

alexmmueller commented Oct 14, 2021 •
edited
Loading

This looks great! Just a small hint: I think "read rights" is not really native language, or?!? I would suggest something like "
'Create new Link' and allow to <read/ edit>" ...

@Tbaut
Copy link
Collaborator Author

Tbaut commented Oct 14, 2021 •
edited
Loading

Sure anything that sounds more right is good.
Note that the video shows the current implementation, which we consider "not good" enough, hence this issue to make it better.

@Tbaut
Copy link
Collaborator Author

Tbaut commented Oct 26, 2021

The design are almost ready here https://www.figma.com/file/wRMGqc11iQLVpDVmqXVXWK/ChainSafe-Files?node-id=2349%3A59153
image

@Tbaut Tbaut mentioned this issue Oct 26, 2021
Closed
@FSM1
Copy link
Contributor

FSM1 commented Nov 3, 2021

image

@Tbaut Tbaut removed Planning: Needs Design 🖼️ This UI component still needs one more designs to complete Planning: Needs estimation labels Nov 3, 2021
@FSM1
Copy link
Contributor

FSM1 commented Nov 3, 2021

Restrict creating links to ones which have not been created yet - The user can only have 2 links (1 read, 1 write), so the link creation part of this dialog should be intelligent enough to only allow the user to create links that they do not have yet.

If a user has 2 links they should not be allowed to create any more.

The 2 section modal will also require some rework on the CustomModal.tsx component, to accomodate this layout.

@Tbaut Tbaut self-assigned this Nov 4, 2021
@Tbaut Tbaut mentioned this issue Nov 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tbaut Tbaut

Labels
Epic: Sharing with link Added to issues due for Sharing v1, allowing to share with any email from Google/Github. Product: Files
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Link sharing redesign ChainSafe/ui-monorepo
3 participants
@FSM1 @Tbaut @alexmmueller