Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove API version from request intercepts #1655

Closed
asnaith opened this issue Oct 25, 2021 · 4 comments · Fixed by #1658
Closed

Remove API version from request intercepts #1655

asnaith opened this issue Oct 25, 2021 · 4 comments · Fixed by #1658
Assignees

Comments

@asnaith
Copy link
Member

asnaith commented Oct 25, 2021

@Tbaut made a good point that the current tests where we are using api stubbing are brittle because we include the full path of the key that is version specific, meaning whenever we update the version of the key we will break the tests.

@asnaith asnaith self-assigned this Oct 25, 2021
@FSM1
Copy link
Contributor

FSM1 commented Oct 25, 2021

Honestly do not think that we will be changing that version string in the API any time soon. If we were to release a major new version, this would likely run in parallel with the V1 API for some time still and would involve so much refactoring in other parts of the system that the tests would likely need to be updated in any case.

@Tbaut
Copy link
Collaborator

Tbaut commented Oct 25, 2021

Yup the api version isn't an issue. The survey banner version is what my comments pointed at #1648 (review)

@FSM1
Copy link
Contributor

FSM1 commented Oct 25, 2021

Yup the api version isn't an issue. The survey banner version is what my comments pointed at #1648 (review)

ahhh ok that makes a lot more sense 💡

@asnaith
Copy link
Member Author

asnaith commented Oct 26, 2021

I was under the impression it was regarding the version in the URL until drinking more coffee and reading Thibaut's comment again 😄. Ultimately it's probably best to stip version specifics from url and key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants