Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new ui test coverage for landing page in Files #2114

Closed
juans-chainsafe opened this issue Apr 28, 2022 · 3 comments · Fixed by #2115
Closed

Add new ui test coverage for landing page in Files #2114

juans-chainsafe opened this issue Apr 28, 2022 · 3 comments · Fixed by #2115
Assignees
Labels
Testing Added to issues to signal that it is part of an epic

Comments

@juans-chainsafe
Copy link
Contributor

As described, add test coverage for the below scenarios:

  • Navigate to the Privacy policy page
  • Navigate to the Terms & Conditions page
  • Navigate to ChainSafe.io from "Learn more about Chainsafe"
  • Accept cookie banner on main page
@juans-chainsafe juans-chainsafe self-assigned this Apr 28, 2022
@juans-chainsafe juans-chainsafe added the Testing Added to issues to signal that it is part of an epic label Apr 28, 2022
@juans-chainsafe juans-chainsafe changed the title Add new ui test coverage for navigation in landing page Add new ui test coverage for landing page Apr 28, 2022
@juans-chainsafe
Copy link
Contributor Author

I will not include "Accept cookie banner on main page" testcase because "accept cookies" doesn't appear in localhost

@juans-chainsafe juans-chainsafe linked a pull request May 3, 2022 that will close this issue
@juans-chainsafe juans-chainsafe changed the title Add new ui test coverage for landing page Add new ui test coverage for landing page in Files May 3, 2022
@Tbaut
Copy link
Collaborator

Tbaut commented May 4, 2022

I believe this is not a localhost specific issue, it's more the fact that posthog (our metric tracking system) is not properly set up in the environment and we default to not tracking anything, therefore there's no need for a banner. So if needed, we can make sure the banner actually appears. The only annoyance is that we may have to click it away for all the test run (<- not 100% sure this is needed, we should check if some tests fail because some UI element are hidden because of the banner)

@juans-chainsafe
Copy link
Contributor Author

@Tbaut nice, if we don't close that banner in all the test cases I believe that some could fail, because is true that some elements could be hidden because of the banner, but in that case we can add to the web3Login command (at the end) to accept cookies (as well I think cypress has something to automatically accept cookies, but I'm not sure)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing Added to issues to signal that it is part of an epic
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants