Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No preview available for files in Bin folder #873

Closed
sweetpea22 opened this issue Apr 5, 2021 · 3 comments · Fixed by #905
Closed

No preview available for files in Bin folder #873

sweetpea22 opened this issue Apr 5, 2021 · 3 comments · Fixed by #905
Assignees
@tanmoyAtb
Labels
Priority: P1 High Added to issues relating to a high severity bugs. Type: Bug Fix Added to PRs if they are addressing a bug

Comments

@sweetpea22
Copy link
Contributor

Hey not sure if this is intentional. Perhaps we should show an error if it is.
Screen Shot 2021-04-05 at 1 44 52 PM
@Tbaut Tbaut added package: Files-UI Type: Bug Fix Added to PRs if they are addressing a bug and removed question labels Apr 6, 2021
@Tbaut
Copy link
Collaborator

Tbaut commented Apr 6, 2021

I think it's important to be able to have the preview in the bin, to be able to double check what's to be deleted.

@sweetpea22
Copy link
Contributor Author

Agreed!

@FSM1
Copy link
Contributor

FSM1 commented Apr 6, 2021

Adding this in should be a couple lines of code :)

@FSM1 FSM1 added the Priority: P1 High Added to issues relating to a high severity bugs. label Apr 7, 2021
@tanmoyAtb tanmoyAtb self-assigned this Apr 8, 2021
@tanmoyAtb tanmoyAtb mentioned this issue Apr 9, 2021
Merged
@FSM1 FSM1 closed this as completed in #905 Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tanmoyAtb tanmoyAtb

Labels
Priority: P1 High Added to issues relating to a high severity bugs. Type: Bug Fix Added to PRs if they are addressing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

file preview bin ChainSafe/ui-monorepo
4 participants
@tanmoyAtb @FSM1 @Tbaut @sweetpea22