Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] highlight when triggering pan gesture in default scale not working #520

Closed
liuxuan30 opened this issue Oct 30, 2015 · 1 comment
Closed

Comments

@liuxuan30
Copy link
Member

For commit 1d53151

It turned out that below cause the problem:

if !_dataNotSet && _dragEnabled &&
    (!self.hasNoDragOffset || !self.isFullyZoomedOut || self.isHighlightPerDragEnabled)
{
    _isDragging = true
    ...
}

Why || self.isHighlightPerDragEnabled here? It will make the whole if condition always true and lead _isDragging to true. then

else if (recognizer.state == UIGestureRecognizerState.Changed)
{
    if (_isDragging)
    {
        ...
    }

will always goes in isDragging, not triggering the highlight code path.

@liuxuan30
Copy link
Member Author

Have a fix ready. Correct me if I misunderstood or missed anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant