Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Axis Renderers Cleanup #3164

Merged
merged 20 commits into from
Jan 4, 2019
Merged

Axis Renderers Cleanup #3164

merged 20 commits into from
Jan 4, 2019

Commits on Dec 25, 2018

  1. Cleaned up ChartDataSet logic 

    Added TODOs for areas where simple changes can help improve Swift consistency.
    @jjatie
    jjatie committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    aa7e20a View commit details
    Browse the repository at this point in the history

  2. Added Collection conformances 

    MutableCollection
RandomAccessCollection
RangeReplaceableCollection
    @jjatie
    jjatie committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    438dae7 View commit details
    Browse the repository at this point in the history

  3. [#3018] 

    Refactored use of `ChartData` to use new `Collection` conformances
    @jjatie
    jjatie committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    8aba022 View commit details
    Browse the repository at this point in the history

  4. Fixed required initializers

    @jjatie
    jjatie committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    2ced54f View commit details
    Browse the repository at this point in the history

  5. ChartData adopts ExressibleByArrayLiteral

    @jjatie
    jjatie committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    7dfb59e View commit details
    Browse the repository at this point in the history

  6. Modified demos 

    to take advantage of collection conformance.
    @jjatie
    jjatie committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    b554fb0 View commit details
    Browse the repository at this point in the history

  7. Pulled latest master

    @jjatie
    jjatie committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    51501a1 View commit details
    Browse the repository at this point in the history

  8. Unified Style 

    Replaced custom algorithms with built-in ones
Made axis renderer implementations feel "Swift-ier"
    @jjatie
    jjatie committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    78fb682 View commit details
    Browse the repository at this point in the history

  9. Updates for PR 

    Also added remove subrange.
    @jjatie
    jjatie committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    bdf6f6d View commit details
    Browse the repository at this point in the history

  10. Refactored ChartData 

    Removed redundancy from min/max logic.
Lots of naming changes.
Cleaner implementations.
    @jjatie
    jjatie committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    da2ff2d View commit details
    Browse the repository at this point in the history

  11. Fixed horizontal barchart bug,

    @jjatie
    jjatie committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    9aaee13 View commit details
    Browse the repository at this point in the history

  12. Removed unnecessary get from subscripts.

    @jjatie
    jjatie committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    f399bca View commit details
    Browse the repository at this point in the history

  13. Disabled remove(at:) for CombinedChartView

    @jjatie
    jjatie committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    bd1bc8f View commit details
    Browse the repository at this point in the history

  14. Relocated appendEntry(_:todataSet:)

    @jjatie
    jjatie committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    74f28b1 View commit details
    Browse the repository at this point in the history

  15. Disabled Collection support for CombinedChartData

    @jjatie
    jjatie committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    aec150e View commit details
    Browse the repository at this point in the history

  16. Removed used of dataSet(forIndex:)

    @jjatie
    jjatie committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    f606175 View commit details
    Browse the repository at this point in the history

  17. Fixed merge conflicts

    @jjatie
    jjatie committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    6db01d2 View commit details
    Browse the repository at this point in the history

  18. updated demos

    @jjatie
    jjatie committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    b8aa08e View commit details
    Browse the repository at this point in the history

  19. PR Fixes

    @jjatie
    jjatie committed Dec 25, 2018
    Configuration menu
    Copy the full SHA
    6d8471d View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2019

  1. Fixed axisLabels calculation

    Jacob Christie committed Jan 3, 2019
    Configuration menu
    Copy the full SHA
    52480db View commit details
    Browse the repository at this point in the history