Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove time.sleep at the end of run #171

Merged
merged 1 commit into from
Aug 24, 2023
Merged

chore: remove time.sleep at the end of run #171

merged 1 commit into from
Aug 24, 2023

Conversation

baruchiro
Copy link
Contributor

Fixes #59

First I notices we're not waiting for the PreRun routine that handles all the channels.

Then, to Done the routine that listen to the channel, I need to close the channel.

@github-actions
Copy link

kics-logo

KICS version: v1.7.4

Category Results
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 1
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 1
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 49
Queries failed to execute placeholder 0
Execution time placeholder 1

@baruchiro baruchiro changed the title Remove time.sleep at the end of run chore: remove time.sleep at the end of run Aug 24, 2023
joaopedrocsilva
joaopedrocsilva approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@joaopedrocsilva joaopedrocsilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Everything seems great for me.

Great job @baruchiro!

@baruchiro baruchiro added this pull request to the merge queue Aug 24, 2023
@baruchiro baruchiro removed the request for review from jossef August 24, 2023 11:29
Merged via the queue into master with commit d4fada8 Aug 24, 2023
@baruchiro baruchiro deleted the baruchiro/Remove-timesleep-at-the-end-of-run branch August 24, 2023 11:31
@baruchiro baruchiro mentioned this pull request Aug 24, 2023
Merged
@baruchiro
Copy link
Contributor Author

Yay! 🎉
Your Pull Request was merged! Thank you for your contribution to this Open Source project. We appreciate your work and dedication. 😊

We would love to hear your feedback on your experience of working on this project. Please take a few minutes to answer this short survey.
Your responses will help us improve the project and make it more enjoyable for future contributors.

Thank you again for your valuable input and we hope to see you again soon! 👋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaopedrocsilva joaopedrocsilva joaopedrocsilva approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove time.sleep at the end of run
2 participants
@baruchiro @joaopedrocsilva