From bdbc50a920402758e7e4a26b0fe2e91ea8b8bba5 Mon Sep 17 00:00:00 2001 From: KN4CK3R Date: Wed, 29 Dec 2021 12:40:57 +0100 Subject: [PATCH] Set HeadCommit when creating tags. (#18116) Co-authored-by: wxiaoguang --- services/release/release.go | 6 +++++- services/repository/push.go | 11 ++++++++++- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/services/release/release.go b/services/release/release.go index e20b91ece0739..5fa506bc61841 100644 --- a/services/release/release.go +++ b/services/release/release.go @@ -72,13 +72,17 @@ func createTag(gitRepo *git.Repository, rel *models.Release, msg string) (bool, created = true rel.LowerTagName = strings.ToLower(rel.TagName) + commits := repository.NewPushCommits() + commits.HeadCommit = repository.CommitToPushCommit(commit) + commits.CompareURL = rel.Repo.ComposeCompareURL(git.EmptySHA, commit.ID.String()) + notification.NotifyPushCommits( rel.Publisher, rel.Repo, &repository.PushUpdateOptions{ RefFullName: git.TagPrefix + rel.TagName, OldCommitID: git.EmptySHA, NewCommitID: commit.ID.String(), - }, repository.NewPushCommits()) + }, commits) notification.NotifyCreateRef(rel.Publisher, rel.Repo, "tag", git.TagPrefix+rel.TagName) rel.CreatedUnix = timeutil.TimeStampNow() } diff --git a/services/repository/push.go b/services/repository/push.go index c8ac5b28947a2..fe3f32f839632 100644 --- a/services/repository/push.go +++ b/services/repository/push.go @@ -121,13 +121,22 @@ func pushUpdates(optsList []*repo_module.PushUpdateOptions) error { delTags = append(delTags, tagName) notification.NotifyDeleteRef(pusher, repo, "tag", opts.RefFullName) } else { // is new tag + newCommit, err := gitRepo.GetCommit(opts.NewCommitID) + if err != nil { + return fmt.Errorf("gitRepo.GetCommit: %v", err) + } + + commits := repo_module.NewPushCommits() + commits.HeadCommit = repo_module.CommitToPushCommit(newCommit) + commits.CompareURL = repo.ComposeCompareURL(git.EmptySHA, opts.NewCommitID) + notification.NotifyPushCommits( pusher, repo, &repo_module.PushUpdateOptions{ RefFullName: git.TagPrefix + tagName, OldCommitID: git.EmptySHA, NewCommitID: opts.NewCommitID, - }, repo_module.NewPushCommits()) + }, commits) addTags = append(addTags, tagName) notification.NotifyCreateRef(pusher, repo, "tag", opts.RefFullName)