Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document maximum character limitation in docs #37

Closed
tomschenkjr opened this issue Mar 19, 2018 · 3 comments
Closed

Document maximum character limitation in docs #37

tomschenkjr opened this issue Mar 19, 2018 · 3 comments
Assignees
Milestone

Comments

@tomschenkjr
Copy link
Contributor

Our current limitation is 20,000 characters (including whitespaces).

@tomschenkjr tomschenkjr self-assigned this Mar 19, 2018
@tomschenkjr tomschenkjr added this to the v1.0.0-rc.3 milestone Mar 19, 2018
@geneorama
Copy link
Member

I'm hoping to get more clarity on the performance issues from Sun and George in the coming days before we declare a hard limit.

Currently there are performance issues with larger files, e.g. files that are more than 10k characters in length. Although this is a large file for what we're expecting, the technology should be able to handle this file size with no problem.

In fact, each component seems to perform as expected, and it's unclear why the performance issue is cropping up.

@tomschenkjr
Copy link
Contributor Author

@geneorama - Per our discussion today, please set the maximum to 20,000 characters in the documentation. In the future, if we determine that more are needed, we can increase it without breaking existing processes.

@geneorama
Copy link
Member

Added note in the api docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants