Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge in changes for rc3 #41

Merged
merged 8 commits into from
Apr 4, 2018
Merged

Merge in changes for rc3 #41

merged 8 commits into from
Apr 4, 2018

Conversation

geneorama
Copy link
Member

Changes for 1.0.0-rc3

geneorama and others added 7 commits March 23, 2018 13:54
Copy/pasted this from the Chicago/open311-api-docs repo. It uses the
same key as that workflow. The target directory is
`dev.cityofchicago.org/docs/lead-safe`.
 - fixed website
 - added CDPH phone number
 - deleted placeholder text
@geneorama geneorama requested a review from tomschenkjr April 3, 2018 21:35
Copy link
Contributor

@tomschenkjr tomschenkjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the changes, but please hold from merging until we actually deploy the code to production.

After merging, please create a new release/tag and document the changes.

@tomschenkjr
Copy link
Contributor

@geneorama - In addition to my notes for the approval (above), after you merge, you can check the deployment on Travis CI. It is programmed to only deploy to S3 when code hits the master branch. That is, it'll build with any commit, but only deploy from master.

There will be text on the bottom indicating that files are copied to Travis. If it works, it is programmed to deploy to http://dev.cityofchicago.org/docs/lead-safe

@tomschenkjr
Copy link
Contributor

Because I didn't realize it had been deployed, I am merging the pull request.

Would still ask that @geneorama do the release notes on this one.

@tomschenkjr tomschenkjr merged commit 273cb19 into master Apr 4, 2018
@tomschenkjr
Copy link
Contributor

@geneorama - hold for a sec on the new release. Had a deployment error in Travis and may need to tweak the .travis-ci.yaml file, first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants