-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge in changes for rc3 #41
Conversation
1.0.0-rc3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the changes, but please hold from merging until we actually deploy the code to production.
After merging, please create a new release/tag and document the changes.
@geneorama - In addition to my notes for the approval (above), after you merge, you can check the deployment on Travis CI. It is programmed to only deploy to S3 when code hits the There will be text on the bottom indicating that files are copied to Travis. If it works, it is programmed to deploy to http://dev.cityofchicago.org/docs/lead-safe |
Because I didn't realize it had been deployed, I am merging the pull request. Would still ask that @geneorama do the release notes on this one. |
@geneorama - hold for a sec on the new release. Had a deployment error in Travis and may need to tweak the |
Changes for 1.0.0-rc3