Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removeItem event callback doesn't include customProperties #774

Closed
adilyalcin opened this issue Nov 23, 2019 · 1 comment
Closed

removeItem event callback doesn't include customProperties #774

adilyalcin opened this issue Nov 23, 2019 · 1 comment
Labels

Comments

@adilyalcin
Copy link

Hi,

As noted in issue title, removeItem event callback doesn't include customProperties on event.detail object. event.detail only includes id, value, label

Related section that explicitly sets only id, value, label:
https://github.com/jshjohnson/Choices/blob/master/src/scripts/choices.js#L1869 )

addItem includes customProperties correctly, as well as groupValue - I'm not sure if that'd apply for removeItem, but just for your information.

Thanks !

@jshjohnson jshjohnson added the bug label Nov 23, 2019
@jshjohnson jshjohnson mentioned this issue Nov 24, 2019
8 tasks
@adilyalcin
Copy link
Author

Awesome! Thanks @jshjohnson . I'll apply the fix when new version is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants