Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change install to winget, nuget, msstore #3088

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

ChrisTitusTech
Copy link
Owner

@ChrisTitusTech ChrisTitusTech commented Dec 6, 2024

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

This was a complete re-write of how winget get installed or updated. The old github method would fail a lot as the packages are updated often. The choco package fallback always fails since it is never up to date as well.

I switched to using the out of date winget to update winget for method 1
if this fails, we switch to using the ms store for method 2
finally we can also use nuget to install for the final try.

Resolves Issues

#3073
#3051
#3003
#3078

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@ChrisTitusTech ChrisTitusTech merged commit d6c1fbe into main Dec 6, 2024
4 checks passed
@ChrisTitusTech ChrisTitusTech deleted the winget-revamp branch December 6, 2024 03:18
@Squtzy
Copy link

Squtzy commented Dec 8, 2024

Hi, has this fixed been "deployed" as of the time of this comment? I am still getting the error that was mentioned in a issue that this PR was mentioned in :)

@ChrisTitusTech
Copy link
Owner Author

Hi, has this fixed been "deployed" as of the time of this comment? I am still getting the error that was mentioned in a issue that this PR was mentioned in :)

This is only on the windev run. I'll deploy it to stable after it is tested more.

@stamminator
Copy link

stamminator commented Dec 9, 2024

When I try to run windev, I'm getting an exception at launch:

Exception setting "WindowTitle": "Window title cannot be longer than 1023 characters."
At line:80 char:1
+ $Host.UI.RawUI.WindowTitle = $myInvocation.MyCommand.Definition + "(A ...

winutil_2024-12-09_15-01-06.log

The winget reinstall also still doesn't work for me. It doesn't appear in the logs, but here are the errors in the console output:

Chocolatey v2.4.1
3 validations performed. 2 success(es), 1 warning(s), and 0 error(s).

Validation Warnings:
 - A pending system reboot request has been detected, however, this is
   being ignored due to the current Chocolatey configuration.  If you
   want to halt when this occurs, then either set the global feature
   using:
     choco feature enable --name="exitOnRebootDetected"
   or pass the option --exit-when-reboot-detected.

Installing the following packages:
winget
By installing, you accept licenses for the packages.
Downloading package from source 'https://community.chocolatey.org/api/v2/'
Progress: Downloading microsoft-ui-xaml-2-7 2.7.3... 100%

microsoft-ui-xaml-2-7 v2.7.3 (forced) [Approved]
microsoft-ui-xaml-2-7 package files install completed. Performing other installation steps.
ERROR: The type initializer for '<Module>' threw an exception.
The install of microsoft-ui-xaml-2-7 was NOT successful.
Error while running 'C:\ProgramData\chocolatey\lib\microsoft-ui-xaml-2-7\tools\chocolateyInstall.ps1'.
 See log for details.
Downloading package from source 'https://community.chocolatey.org/api/v2/'
Progress: Downloading microsoft-vclibs-140-00 14.0.33321... 100%

microsoft-vclibs-140-00 v14.0.33321 (forced)
microsoft-vclibs-140-00 package files install completed. Performing other installation steps.
ERROR: The type initializer for '<Module>' threw an exception.
The install of microsoft-vclibs-140-00 was NOT successful.
Error while running 'C:\ProgramData\chocolatey\lib\microsoft-vclibs-140-00\tools\chocolateyInstall.ps1'.
 See log for details.
Failed to install winget-cli because a previous dependency failed.
Failed to install winget because a previous dependency failed.

Chocolatey installed 0/4 packages. 4 packages failed.
 See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).

Failures
 - microsoft-ui-xaml-2-7 (exited -1) - Error while running 'C:\ProgramData\chocolatey\lib\microsoft-ui-xaml-2-7\tools\chocolateyInstall.ps1'.
 See log for details.
 - microsoft-vclibs-140-00 (exited -1) - Error while running 'C:\ProgramData\chocolatey\lib\microsoft-vclibs-140-00\tools\chocolateyInstall.ps1'.
 See log for details.
 - winget - Failed to install winget because a previous dependency failed.
 - winget-cli - Failed to install winget-cli because a previous dependency failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants