Resolve mariadb for mysql contextually

[apotek]

Description

Adds a Robo task that provides a facility for being able to choose which binary to use depending on environment.

Motivation / Context

I wanted to get ahead of the fact that tugboat will soon be switching to mariadb binaries with no symlinking from mysql.

Which made me think it would be good to create a Robo task/utility for being able to switch between binaries, depending on the operating environment.

I used this also an a chance to get to know Robo just a bit. I could obviously have implemented this in a simpler way just for our use case.

I was going to contribute the "Alternatives" task as a Robo task to packagist and then import it, but I felt at this early stage it might be better to keep things simple and just add it to Usher.

Sounds good, but why are there so many changes to databaseRefreshTugboat?

I noticed that there was no consistent handling of "result" in that function. Result kept getting overwritten, meaning that the returned result at the end was basically meaningless. On top of that, if an exception occurred in attempting to get the dbPath, and there was only one site, there would be a return of NULL, which broke the function signature.

Lando?

I also added a .lando file so I could easily test some robo stuff in situ without having to import usher into another project just to test something.

Resolves: #159

[ghost]

👇 Click on the image for a new way to code review

Legend

[apotek]

phpstan is throwing an error that I disagree with:

phpstan:

Error: Variable $dbPath in isset() always exists and is not nullable.

---

Line src/Robo/Plugin/Commands/DevelopmentModeBaseCommands.php

---

140 Variable $dbPath in isset() always exists and is not nullable.

---

But $dbPath will certainly not exist, if an exception occurs on line 133. So we need the isset() on line 140.

            try {
                $dbPath = $this->databaseDownload($siteName);
            } catch (TaskException $te) {
                $this->yell("$siteName: No database configured. Download/import skipped.");
                $result_data->append($te->getMessage());
                // @todo: Should we run a site-install by default?
                continue;
            }
            if (!isset($dbPath) || !is_string($dbPath) || strlen($dbPath) == 0) {

[adamzimmermann]

Some questions (mostly out of my own ignorance), but this is great work. 👏🏼

Perhaps we can begin using this as is, but also begin working on trying to get something like this into Robo as a Plan B/long-term play?

[apotek]

Some questions (mostly out of my own ignorance), but this is great work. 👏🏼

Perhaps we can begin using this as is, but also begin working on trying to get something like this into Robo as a Plan B/long-term play?

The "official" way to add tasks, is to simply put what I have in src/Robo/Task/Discovery into a php package with a robo-task type. So that would be an open source contrib and would then not need to be approved by Robo maintainers. But I suppose I could fork and make a merge request too. I'm open to it, if only because I think it would be interesting to see all the feedback about what I have done wrong (which would teach me more about Robo).

[adamzimmermann]

I'm going to defer final approval to @markdorison here. Looking good to me though.

[apotek]

@markdorison I left a question re Symfony versus php-fpm container style.