Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor how Usher handles loading required vs optional site configuration #169

Open
markdorison opened this issue Sep 27, 2023 · 0 comments
Assignees

Comments

@markdorison
Copy link
Contributor

Description

Refactor how Usher handles loading required vs optional site configuration. @apotek suggested we take a look at this after the changes introduced in #168

Issue Owner

Proposed Solution

Create a list of site config keys that are required (in a struct?) and only throw exceptions if a missing key is in that list.

Alternatives Considered

  1. Leave things the way they are.
  2. Use helper methods instead of a struct.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant