Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore Gradle Cache Test #51

Closed
FelicianoTech opened this issue Jun 29, 2022 · 6 comments
Closed

Restore Gradle Cache Test #51

FelicianoTech opened this issue Jun 29, 2022 · 6 comments

Comments

@FelicianoTech
Copy link
Contributor

We should test what PR #50 fixes. Setting a default and not should be tested.

@EricRibeiro
Copy link
Contributor

@ryanbourdais, please correct me if I'm wrong, but I believe multiple jobs in the orb's test suite already cover this change.

Example: https://app.circleci.com/pipelines/github/CircleCI-Public/android-orb/385/workflows/ff8eaabb-1425-43e1-90be-da5e3db7528f/jobs/6008

@ryanbourdais
Copy link
Contributor

@EricRibeiro we had a conversation yesterday in the images meeting about adding an explicit test to restore_gradle_cache because currently
its only called by other commands with overrides to the default parameter value. So there is no case that it runs in its default state

@EricRibeiro
Copy link
Contributor

its only called by other commands with overrides to the default parameter value

What is overriding the default parameter value in the link I shared above?

@ryanbourdais
Copy link
Contributor

@EricRibeiro you're right that one isn't overriden, I must have overlooked it when I was checking yesterday. I'm now extra confused on how the error wasn't caught in testing.

@EricRibeiro
Copy link
Contributor

I'm now extra confused on how the error wasn't caught in testing.

The author mentioned this in #49:

I also observed that, for the "test-emulator-commands" job triggered from PR #48, it somehow did not pick up the code changes from #48 and this ran fine;
It was running with the restore-gradle-cache command from v2.1.0 instead.
We can see this under the config, when clicking on "Compiled":
https://app.circleci.com/projects/github/CircleCI-Public/android-orb/config/?branchName=&pipelineNumber=329

I am not sure what caused the issue above, but it's the reason the tests didn't pick up the error.

@FelicianoTech
Copy link
Contributor Author

Just going to close this for now. Not sure what to do with this at the moment and there hasn't been any customer complaints.

@FelicianoTech FelicianoTech closed this as not planned Won't fix, can't repro, duplicate, stale Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants