-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore Gradle Cache Test #51
Comments
@ryanbourdais, please correct me if I'm wrong, but I believe multiple jobs in the orb's test suite already cover this change. |
@EricRibeiro we had a conversation yesterday in the images meeting about adding an explicit test to restore_gradle_cache because currently |
What is overriding the default parameter value in the link I shared above? |
@EricRibeiro you're right that one isn't overriden, I must have overlooked it when I was checking yesterday. I'm now extra confused on how the error wasn't caught in testing. |
The author mentioned this in #49:
I am not sure what caused the issue above, but it's the reason the tests didn't pick up the error. |
Just going to close this for now. Not sure what to do with this at the moment and there hasn't been any customer complaints. |
We should test what PR #50 fixes. Setting a default and not should be tested.
The text was updated successfully, but these errors were encountered: